feat(init): support initializing npm projects #26896
Open
+76
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Nov 16, 2024
cli/main.rs
Outdated
| if dir.starts_with("jsr:") { | ||
| bail!("Initializing project from a jsr package is currently not supported."); | ||
| } else if dir.starts_with("npm:") { | ||
| // TODO: do prompt |
There was a problem hiding this comment.
BLOCKER FOR LANDING:
Do the confirmation prompt if user wants to allow all permissions and post-install scripts.
There was a problem hiding this comment.
If user doesn't grant it, we should print a message how this could be executed manually using deno run subcommand - eg. deno run npm:create-vite
|
$ deno init npm:preact
error: Could not find a matching package for 'npm:create-preact' in the node_modules directory. Ensure you have all your JSR and npm dependencies listed in your deno.json or package.json, then run `deno install`. Alternatively, turn on auto-install by specifying `"nodeModulesDir": "auto"` in your deno.json file.EDIT: Ignore what I wrote. I had a |
|
Thanks, I know what the problem is, will fix it tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for
deno init npm:<package>.Running this will actually call to
npm:create-<package>package thatis equivalent to running
npm create <package>.User will be prompted if they want to allow all permissions and lifecycle scripts
to be executed. It was discussed internally if we should accept permission flags here
but it will be really cumbersome and in most cases these creation scripts need to do
a lot of crazy stuff including reaching out to networks, reading and writing to file system,
reading env vars and spawning subprocesses.
Closes #26461